Fixed a regression where add_field is no longer enriching events
#59
Conversation
|
The test failure using logstash main is somewhat concerning. It is using jruby cc @jsvd who is working on jruby bump. |
|
Would it be feasible to add a regression test for enrichment behavior? |
| @properties_setter.call(event, properties) | ||
| end | ||
|
|
||
| decorate(event) |
|
@donoghuc @mashhurs I would like to add a regression test as a followup task for all input plugins, like how we did in devutils and beats-input The test fails in main branch is concerning although I cannot replicate the issue in local environment with jruby 9.4.14.0 I would like to get this merge today before the feature freeze tmr. Is it okay for you both? |
|
The failure of CI in main branch is caused by Created an issue to follow up the test #60 |
3 participants
Add back the
decorate(event)to allowadd_fieldenriching event#58